-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n-dimensional support via parse_index #41
Conversation
…re_nan flag when serializing the payload
…sive work/testing
…labels in 0/1d cases
- eg, replaced `[this._nrow, this._ncol]` with just `this._n`, etc
The PR now adds full support for all 0D, 1D, 2D, and beyond cases. I've tested it, and I think this is ready to go in. There is still some unfinished business listed on the checklist in this PR's first post. These issues are all a bit out of the scope of enabling basic n-dimensional support, so I'll address these remaining issues in future PRs. As a note to myself, when the code here raises an error, in addition to doing what it's supposed to it also raises an extra "uncaught in promise error": Lines 121 to 152 in 0531f3f
|
Fixes #4, #18, #22, #37
Adds support for datasets with
ndim >2
(issue #4) as well as datasets withndim<=1
(issue #18). The slice input box will now accept the complete subset of numpy indices that are some combination of integer indexes and slices. Though for practical purposes of display, the number of slices in the supplied index has to be between 0-2.The PR is now mostly done. Still needs a couple of things:
This PR should also fix the bugs reported in #22 and #37, due to the complete overhaul of how data and metadata is handled, and also thanks to @JonjonHays handy json fix.