Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slicing of datasets #8

Closed
telamonian opened this issue Aug 21, 2019 · 2 comments
Closed

Add slicing of datasets #8

telamonian opened this issue Aug 21, 2019 · 2 comments

Comments

@telamonian
Copy link
Member

Related to n-dimensional dataset support in #4. Add support to the hdf data models (and thereby to the dataset grids) for showing arbitrary 2D slices. Will use a Numpy-like syntax.
telamonian added a commit that referenced this issue Aug 21, 2019
@telamonian
WIP #8: fixed issue with shape of slices
1036c5f
@telamonian
Copy link
Member Author

telamonian commented Aug 21, 2019 •
edited
Loading

slicing was added in 7c097e2, but it's still buggy. Remaining issues:

  • slices have the wrong shape (too big)
  • when a new slice is made, data won't show/be loaded until a scroll event
  • no support for half-open slices (eg 50:)
  • ensure that empty slice (ie '') is treated as all

telamonian added a commit that referenced this issue Aug 21, 2019
@telamonian
WIP #8: progress on improving slicing
5917b19
telamonian added a commit that referenced this issue Aug 21, 2019
@telamonian
WIP #8: fixed grid refresh after slicing
dadf819
telamonian added a commit that referenced this issue Aug 22, 2019
@telamonian
WIP #8: added correct behavior for half-open slice and for no slices
6881255
@telamonian
Copy link
Member Author

The "Slice" input box now takes a 2D slice (in Numpy syntax) and will behave correctly. This closes out this issue. More improvements are needed for slicing/slice input:

  • make sure that all invalid slices are correctly handled
  • add UX such that the user is quietly informed of the correct syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@telamonian