check for changed files when discarding all changes #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bug where options was referred to when it was undefined.
|
|
fcollonval
approved these changes
Nov 12, 2020
Closed
This was referenced Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when discarding all changed files it was never checked what the names of the changed files were. This meant that open editors were not updated when the files changes. As well this led to a bug where options was referred to even when undefined.
Now we check for the changed files before doing the checkout to all us to pick up the changes in the case of discard all, and will fall back to querying the list of currently modified files if the
bodyhas no filename or branch name.Closes: #823
attn: @lresende