Reduce polling

[fcollonval]

This reduce refresh polling.

Refresh is blocked if:

• Not in a git repository
• The Git tab is hidden (this can be turned off with the setting refreshIfHidden)

[ianhi]

Is it possible to immediately start a refresh when the git tab is brought back into view? Otherwise it may end up being that you switch and then need to wait three seconds for a refresh

[ianhi]

This could also be used to implement the ability to ignore repositories (#641) There could a setting that contains a list of filepaths to ignore.

[fcollonval]

Is it possible to immediately start a refresh when the git tab is brought back into view? Otherwise it may end up being that you switch and then need to wait three seconds for a refresh

It is a good suggestion. I'll try to find a way.

This could also be used to implement the ability to ignore repositories (#641) There could a setting that contains a list of filepaths to ignore.

I tend to set won't fix on #641 as the major problem was jupyterlab hanging because of a big repo. So with this PR and the virtual files list, I think if the UI is still hanging it should be investigated instead of hidden.

[fcollonval]

Is it possible to immediately start a refresh when the git tab is brought back into view?

Done 😄

[ianhi]

Looks mostly good except I seem to be getting double status requests:

[ianhi]

Oh hmm. I see the same double status POST on master as well. Is that intentional or is that a bug?

[fcollonval]

Oh hmm. I see the same double status POST on master as well. Is that intentional or is that a bug?

Good catch, I'll take a look

Ok the double call comes from an emitted headChanged signal that triggers a refresh (in GitPanel.componentDidMount). The trigger is by

jupyterlab-git/src/model.ts

Line 713 in a08c424

const headChanged = this._currentBranch !== data.current_branch;

Identity test on object...

[fcollonval]

I replace the test by this one

      const headChanged =
        this._currentBranch.name !== data.current_branch.name ||
        this._currentBranch.top_commit !== data.current_branch.top_commit;

I think testing for the branch name and top commit get us cover.