-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtualized files list #767
Conversation
This is an early prototype - styling issues need to be addressed (i.e. height handling). But at least it shows that windowing the files list will fix the performance issue. |
137fd8f
to
662b93c
Compare
@ianhi I'll go ahead and merge this one as I need it for other improvements. But if you could check you don't see any glitches on the master after that, I'll appreciate. |
👍 will do |
This fixes the total freezing of the UI and I don't think it introduced any bugs - so hooray! We should maybe still consider compressing the result of status? When I create 10000 files the status request starts to get large and while it's still pretty quick at At least one person reported that the payload was very large for them: #667 (comment) |
* Virtualized files list * Windowing on history files list * Window on branches list * Handle filter branch list * Correct unit test
@fcollonval Great this gets fixed in 0.2.X! Is there any concern back porting this fix to 0.10.x and include in a new release? |
We don't have bandwidth to support older versions. But if you are willing to help. You could trigger a backport with the following comment:
If you succeed to make it works. I can make a release. Small question why not on 0.11.x as that is the latest version for JupyterLab 1? |
Use a virtual component to display files list.
Fixes #667
Closes #703
Closes #704
TODO