Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualized files list #767

Merged
merged 7 commits into from
Sep 26, 2020
Merged

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 8, 2020

Use a virtual component to display files list.

Fixes #667
Closes #703
Closes #704

TODO

  • Set nice height strategy
  • Set windowing on history file list
  • Set windowing on branch list

@fcollonval
Copy link
Member Author

This is an early prototype - styling issues need to be addressed (i.e. height handling). But at least it shows that windowing the files list will fix the performance issue.

@fcollonval fcollonval marked this pull request as ready for review September 26, 2020 16:27
@fcollonval
Copy link
Member Author

@ianhi I'll go ahead and merge this one as I need it for other improvements. But if you could check you don't see any glitches on the master after that, I'll appreciate.

@fcollonval fcollonval merged commit e1de278 into jupyterlab:master Sep 26, 2020
@fcollonval fcollonval deleted the fix/issue-667 branch September 26, 2020 16:29
@ianhi
Copy link
Collaborator

ianhi commented Sep 26, 2020

👍 will do

@ianhi
Copy link
Collaborator

ianhi commented Sep 26, 2020

This fixes the total freezing of the UI and I don't think it introduced any bugs - so hooray!

We should maybe still consider compressing the result of status? When I create 10000 files the status request starts to get large and while it's still pretty quick at 65 ms if it gets much longer I suspect it will start to feel laggy:
image

At least one person reported that the payload was very large for them: #667 (comment)

@ianhi ianhi mentioned this pull request Sep 28, 2020
fcollonval added a commit that referenced this pull request Oct 4, 2020
* Virtualized files list

* Windowing on history files list

* Window on branches list

* Handle filter branch list

* Correct unit test
@ZhangHan
Copy link

@fcollonval Great this gets fixed in 0.2.X! Is there any concern back porting this fix to 0.10.x and include in a new release?

@fcollonval
Copy link
Member Author

@fcollonval Great this gets fixed in 0.2.X! Is there any concern back porting this fix to 0.10.x and include in a new release?

We don't have bandwidth to support older versions. But if you are willing to help. You could trigger a backport with the following comment:

@meeseeksdev backport to 0.10.x

If you succeed to make it works. I can make a release.

Small question why not on 0.11.x as that is the latest version for JupyterLab 1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants