Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog when checking out remote branch #1366

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

gjmooney
Copy link
Contributor

Addresses #1352.

Based on @jtpio's suggestion I added a confirmation dialog when checking out a remote branch that could potentially cause a loss of changes on a users local branch.

confirm_checkout

Copy link

Binder 👈 Launch a Binder on branch gjmooney/jupyterlab-git/remote_checkout_confirmation

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Oct 25, 2024

Wondering if it could be worth reconsidering the use of the -B flag for the git checkout command? To be able to have a similar workflow as when using the git command directly (detached mode, and no commit lost).

Something we could track in a separate issue, as it may require more work and would likely change the current behavior, as discussed in #1352.

@jtpio jtpio merged commit 0ed27e7 into jupyterlab:main Oct 25, 2024
9 of 10 checks passed
@jtpio
Copy link
Member

jtpio commented Oct 25, 2024

Something we could track in a separate issue

Opened #1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants