Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu on commits in the HistorySidebar with add tag command #1277

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Oct 19, 2023

Created a context menu for the commits showing inside the HistorySidebar and added a new command Add Tag.

Users can now right click on a commit and use the Add Tag command to directly create a tag pointing to that specific commit. Once clicking on the command, the NewTagDialogBox pops up, showing only the selected commit.

Screencast-Add-Tag-from-Context-Menu.webm

@github-actions
Copy link

Binder 👈 Launch a Binder on branch DenisaCG/jupyterlab-git/newTaginHistorySidebar

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Denisa, I have only a single request. Would you mind not rendering the filter div when isSingleCommit == true in the NewTagDialog?

@DenisaCG
Copy link
Member Author

Thank you for the review, Frédéric! And great point, I made the changes such that the filter input box disappears when adding a tag from the context menu. I'm also working on creating an integration test.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DenisaCG

@fcollonval fcollonval merged commit 924be51 into jupyterlab:main Oct 23, 2023
8 checks passed
@DenisaCG DenisaCG deleted the newTaginHistorySidebar branch October 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants