Hotfix/dependency update #1249
Hotfix/dependency update #1249
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
|
There was a problem hiding this comment.
Thanks @mfakaehler
One change is unneeded but the README change looks good.
pyproject.toml
Outdated
| @@ -1,3 +1,3 @@ | |||
| [build-system] | |||
| requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*", "packaging", "setuptools>=40.8.0", "wheel"] | |||
| requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*,<4", "packaging", "setuptools>=40.8.0", "wheel"] | |||
There was a problem hiding this comment.
That one is not needed because it is use only to build the package and Python requirement >=3.0.0rc13,==3.* is equivalent to >=3.0.0rc13 and ==3.* (see PEP)
| requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*,<4", "packaging", "setuptools>=40.8.0", "wheel"] | |
| requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*", "packaging", "setuptools>=40.8.0", "wheel"] |
|
Maybe one should also mark the dependency problem in the conda-forge feedstock? |
Make imcompatibility to jupyterlab 4 explicit
fcollonval
force-pushed
the
hotfix/dependency_update
branch
from
47b21f2 to
bb0086e
Compare
|
Congrats on your first merged pull request in this project! 🎉 |
Until issue #1245 and PR #1236 are resolved, I propose to update the dependencies in the README.md and pyproject.toml files to make the current incompatability to jupyterlab 4 explicit.
Please, feel free to make any adjustments.
If you feel it is unnecessary to document this (probably) intermediate issue of incompatibility, please feel free to deny the pull request.