fix switch from a detached head to a branch not working

[basokant]

Provides fix for #995

If the repository is in detached head (for example after switching to a tag), then switching to a branch will no longer fail. Behaviour after changes:

955-fix.mov

Transforms the fake branch name (HEAD detached at #####) to ##### using Regex.

[github-actions]

👈 Launch a binder notebook on branch basokant/jupyterlab-git/fix-issue-955

[fcollonval]

This looks great 🚀

I'm actually wondering if we should rather clean the current branch name for consistency and to avoid other troubles.

The branch is set at

jupyterlab-git/src/model.ts

Line 1045 in c7e7363

this._currentBranch = data.current_branch;

Would you mind trying applying your fix there to see if it works?

[basokant]

This looks great 🚀

I'm actually wondering if we should rather clean the current branch name for consistency and to avoid other troubles.

The branch is set at

jupyterlab-git/src/model.ts

Line 1045 in c7e7363

this._currentBranch = data.current_branch;

Would you mind trying applying your fix there to see if it works?

Yes I'll try moving the fix there instead 👍 I think that's a good call, I believe this will be more clear to the user on what tag they are checking out.

[fcollonval]

Thanks @basokant

Do you need help to fix the Jest tests?

[fcollonval]

Thanks for fixing the tests.

Are you ok with expanding this to add a new flag detached in Git.IBranch at

https://github.com/jupyterlab/jupyterlab-git/blob/master/src/tokens.ts#L816

And use that flag to tune the branch display at

https://github.com/jupyterlab/jupyterlab-git/blob/master/src/components/Toolbar.tsx#L267

[basokant]

Relocated the translate of the branch toolbar title. Should be ready for a final review @fcollonval

[fcollonval]

Thanks @basokant