Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Cache Credentials for Issue #659 #1091

Closed
wants to merge 11 commits into from
Closed

Frontend Cache Credentials for Issue #659 #1091

wants to merge 11 commits into from

Conversation

ZeshanFayyaz
Copy link
Contributor

Some frontend exploration on #659

Added new interface IAuthWithCacheCredentials that extends IAuth that includes a new boolean that is implemented as a checkbox in CredentialsBox.tsx. and is used in commandsAndMenu.tsx as an additional argument.

When we push and clone we are expecting authentication.cacheCredentials (default False).

@welcome
Copy link

welcome bot commented Mar 17, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch ZeshanFayyaz/jupyterlab-git/March17th_Clone

Comment on lines +64 to 69
getValue(): Git.IAuthWithCacheCredentials {
return {
username: this._user.value,
password: this._password.value
password: this._password.value,
cacheCredentials: this._checkboxCacheCredentials.checked
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would extend Git.IAuth with a new optional parameter cacheCredentials. This will allow you to simply pass-by those information through the model and then to the server. One reason for that is the strong bound between that parameter and the credentials; passing it as a separate argument as done currently would be interesting if it had an effect even if the authentication was not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants