-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Cache Credentials for Issue #659 #1091
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
getValue(): Git.IAuthWithCacheCredentials { | ||
return { | ||
username: this._user.value, | ||
password: this._password.value | ||
password: this._password.value, | ||
cacheCredentials: this._checkboxCacheCredentials.checked | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would extend Git.IAuth
with a new optional parameter cacheCredentials
. This will allow you to simply pass-by those information through the model and then to the server. One reason for that is the strong bound between that parameter and the credentials; passing it as a separate argument as done currently would be interesting if it had an effect even if the authentication was not defined.
Some frontend exploration on #659
Added new interface
IAuthWithCacheCredentials
that extendsIAuth
that includes a new boolean that is implemented as a checkbox inCredentialsBox.tsx.
and is used incommandsAndMenu.tsx
as an additional argument.When we push and clone we are expecting
authentication.cacheCredentials
(default False).