Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests #1019

Merged
merged 5 commits into from
Aug 30, 2021

Conversation

navn-r
Copy link
Collaborator

@navn-r navn-r commented Aug 29, 2021

Adds /ui-tests using Playwright test-runner, currently with one spec for merge conflicts.
Removes /tests/test-browser

cc @fcollonval

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch MLH-Fellowship/jupyterlab-git/feat/integration-testing

@navn-r navn-r force-pushed the feat/integration-testing branch from 4f09e95 to 7046e38 Compare August 29, 2021 17:46
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @navn-r for pushing this.

Two suggestions and it will be good to go.

.github/workflows/build.yml Outdated Show resolved Hide resolved
ui-tests/docker/prepare.sh Outdated Show resolved Hide resolved
Co-authored-by: Frédéric Collonval <[email protected]>
@navn-r navn-r requested a review from fcollonval August 30, 2021 11:56
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for quickly updating this PR

@fcollonval fcollonval merged commit 65f5ed8 into jupyterlab:master Aug 30, 2021
@fcollonval fcollonval deleted the feat/integration-testing branch August 30, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants