-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't erase commit message when commit fails #836
Labels
Comments
fcollonval
added
enhancement
pkg:Frontend
Good first issue
Good first issue to be tackled by new contributors
labels
Nov 30, 2020
The relevant code is in: jupyterlab-git/src/components/CommitBox.tsx Lines 147 to 153 in f60ed32
The |
navn-r
added a commit
to MLH-Fellowship/jupyterlab-git
that referenced
this issue
Jul 6, 2021
navn-r
added a commit
to MLH-Fellowship/jupyterlab-git
that referenced
this issue
Jul 6, 2021
navn-r
added a commit
to MLH-Fellowship/jupyterlab-git
that referenced
this issue
Jul 7, 2021
…jupyterlab#836) - Raise error instead of returning false on fail setting identity
fcollonval
pushed a commit
that referenced
this issue
Jul 8, 2021
… (#971) * Move commit message state to git panel (#931) * Preserve commit message when commit fails (#836) * Fix unit tests from refactor (#931) (#836) * Rename commit message state variables (#931) * summary -> commitSummary * description -> commitDescription * Preserve commit message when refusing to set identity when committing (#836) - Raise error instead of returning false on fail setting identity * Refactor commit and commit message handler functions * GitPanel.commitFiles now handles all commit actions * Refactor GitPanel spec to test commitFiles function instead of commitStaged * Change commit message handler functions to be more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
When using git hook (for example such as black), it may happen that the commit is rejected. Unfortunately in case of error the commit message is erased. It would be nice to keep it as the user will want to carry small correction (like add the black format correction) before retrying to commit.
The text was updated successfully, but these errors were encountered: