Skip to content

Commit

Permalink
Fix integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
krassowski authored and Zsailer committed May 15, 2024
1 parent 7ff623d commit c8b4792
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions ui-tests/tests/file-selection.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ test.describe('File selection for simple staging', () => {
// URL for merge conflict example repository
await page.goto(`tree/${tmpPath}/test-repository`);

// Click [aria-label="main"] >> text=Git
await page.locator('[aria-label="main"] >> text=Git').click();
// Click Git menu
await page.locator('[aria-label="main menu"] >> text=Git').click();
// Click text=Simple staging
await page.getByRole('menuitem', { name: 'Simple staging' }).click();
});
Expand Down
6 changes: 3 additions & 3 deletions ui-tests/tests/rebase.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ test.describe('Rebase', () => {
await expect.soft(banner).toHaveText(/Result/);
await expect.soft(banner).toHaveText(/Incoming/);

await page.getByRole('button', { name: 'Mark as resolved' }).click();
await page.locator('button >> text="Mark as resolved"').click();

Check failure on line 61 in ui-tests/tests/rebase.spec.ts

View workflow job for this annotation

GitHub Actions / Integration tests

tests/rebase.spec.ts:46:7 › Rebase › should resolve a conflicted rebase

1) tests/rebase.spec.ts:46:7 › Rebase › should resolve a conflicted rebase ─────────────────────── Error: locator.click: Page closed =========================== logs =========================== waiting for locator('button').locator('text="Mark as resolved"') ============================================================ 59 | await expect.soft(banner).toHaveText(/Incoming/); 60 | > 61 | await page.locator('button >> text="Mark as resolved"').click(); | ^ 62 | 63 | await page 64 | .getByTitle('another_file.txt • Conflicted', { exact: true }) at /home/runner/work/jupyterlab-git/jupyterlab-git/ui-tests/tests/rebase.spec.ts:61:61

await page
.getByTitle('another_file.txt • Conflicted', { exact: true })
.dblclick();

await page.getByRole('button', { name: 'Mark as resolved' }).click();
await page.locator('button >> text="Mark as resolved"').click();

await page.getByTitle('example.ipynb • Conflicted').click({
clickCount: 2
Expand All @@ -79,7 +79,7 @@ test.describe('Rebase', () => {
await expect.soft(banner).toHaveText(/Current/);
await expect.soft(banner).toHaveText(/Incoming/);

await page.getByRole('button', { name: 'Mark as resolved' }).click();
await page.locator('button >> text="Mark as resolved"').click();

// Continue rebase as all conflicts are resolved
await page.getByRole('button', { name: 'Continue' }).click();
Expand Down

0 comments on commit c8b4792

Please sign in to comment.