Close diff only for file in index or working state (#1140)

Fixes #1137
jupyterlab · Jul 7, 2022 · 0a50d7e · 0a50d7e
1 parent 20bc055
commit 0a50d7e
Showing 1 changed file with 17 additions and 8 deletions.
diff --git a/src/commandsAndMenu.tsx b/src/commandsAndMenu.tsx
@@ -607,14 +607,23 @@ export function addCommands(
             modelIsLoading.reject(msg);
           }
 
-          gitModel.statusChanged.connect((_, status) => {
-            const targetFile = status.files.find(
-              fileStatus => model.filename === fileStatus.from
-            );
-            if (!targetFile || targetFile.status === 'unmodified') {
-              mainAreaItem.dispose();
-            }
-          });
+          if (
+            model.challenger.source === Git.Diff.SpecialRef.INDEX ||
+            model.challenger.source === Git.Diff.SpecialRef.WORKING ||
+            model.reference.source === Git.Diff.SpecialRef.INDEX ||
+            model.reference.source === Git.Diff.SpecialRef.WORKING
+          ) {
+            const maybeClose = (_: IGitExtension, status: Git.IStatus) => {
+              const targetFile = status.files.find(
+                fileStatus => model.filename === fileStatus.from
+              );
+              if (!targetFile || targetFile.status === 'unmodified') {
+                gitModel.statusChanged.disconnect(maybeClose);
+                mainAreaItem.dispose();
+              }
+            };
+            gitModel.statusChanged.connect(maybeClose);
+          }
         }
 
         return mainAreaItem;