-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial server management implementation #71
Merged
lucbouchard1
merged 26 commits into
jupyterlab:master
from
lucbouchard1:electron-launcher
Jul 22, 2017
Merged
Initial server management implementation #71
lucbouchard1
merged 26 commits into
jupyterlab:master
from
lucbouchard1:electron-launcher
Jul 22, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eight bug with footer, other small changes
…ockups presented.
nproctor
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the infrastructure required to support the server management described in #48 in addition to an initial implementation. I'm still working with @cameronoelsen on refining the design, but I want to merge this PR to make work easier for @nproctor.
I refactored the code to run a react-based 'launcher' app before JupyterLab is started. Right now, the app launches directly into JupyterLab by default. There is an additional 'Servers' menu in the menu bar that can be used to either launch the server management UI or launch a new window with another connection. The server management UI is an unstable feature.