-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to JupyterLab 3 #191
Conversation
This is awesome! Somewhere we have the account, certificates, and information needed to create the app for MacOS. Let me know if you want to dive into that and I can track down the needed information. |
Thanks @ellisonbg ! Sure, please share that information with me. Not so urgent but I will need those. |
Are the instructions on the README still valid to test this PR? |
Yes @echarles, yarn commands work for me. I didn't update & test distribution build yet. Are you having any issues?
|
@mbektasbbg No issue, I am on mac, and confused with Then there is |
@echarles readme seems to be pretty outdated. Once I update distribution related code, I will make sure readme is up to date as well. |
Thx a lot @mbektasbbg for working on this. Looking forward the instructions when you will publish them. |
Thx so much @mbektasbbg for this work!! Just yesterday I was discussing this app with @lgfunderburk, in the context of her work at Cybera/Callysto. For some of her use cases, a standalone, self-contained, "native" app would be very valuable. I missed your recent work on it, so it's great to see it moving forward! |
Thanks @fperez! Yes, our goal is to provide a self-contained native app which would also be able to connect to remote Jupyter server backends. |
@echarles you can now follow the updated instructions to create a Mac installer and test. Now we have a self-contained app with its own conda env. bundled in. More updates to follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Happy to merge and iterate, but let's leave this open for a day in case anyone else has feedback
The yarn file has a conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @mbektas for the update!
Given that this is clearly a big improvement compared to the current state on |
Semver File License | ||
=================== | ||
|
||
The semver.py file is from https://github.com/podhmo/python-semver | ||
which is licensed under the "MIT" license. See the semver.py file for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krassowski I copied the LICENSE file as is from jupyterlab repo. I just checked, semver.py is shipped with bundled jupyterlab python package. but I am not sure if it is OK to remove from jupyterlab-desktop license.
I'd say it is OK to remove, since that file was never explicitly included in this repo. |
macOS
Ubuntu
Fedora
Windows