Start ystore in a task #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davidbrochart
force-pushed
the
start-ystore
branch
from
e33d0a9 to
85c5220
Compare
This was referenced May 6, 2024
Merged
jzhang20133
reviewed
May 6, 2024
jupyter_collaboration/rooms.py
Outdated
| @@ -100,7 +103,9 @@ async def initialize(self) -> None: | |||
| # try to apply Y updates from the YStore for this document | |||
| read_from_source = True | |||
| if self.ystore is not None: | |||
| await self.ystore.started.wait() | |||
| if not self.ystore.started.is_set(): | |||
| self.create_task(self.ystore.start()) | |||
There was a problem hiding this comment.
ystore.start() can throw RuntimeException if ystore task group is not None. There is another ystore.start() in yroom broadcast method. Since both the start method is scheduled asynchronously and there could a race condition, either of those two ystore.start() tasks can failed with RuntimeException due to ystore is already started. In this task, it might be ok to fail but in yroom.broadcast method, that exception could cause yroom task group to fail and restarted unless we handle the exception in yroom.broadcast implementation as well.
jzhang20133
approved these changes
May 6, 2024
|
24e8c18 will need jupyter-server/pycrdt-websocket#43. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #303.