Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on how to use Amazon Bedrock #936

Merged
merged 12 commits into from
Aug 10, 2024

Conversation

srdas
Copy link
Collaborator

@srdas srdas commented Aug 6, 2024

Address Issue #924

Added docs to show how to use Amazon Bedrock models with Jupyter AI. Shows how to use both base models and custom models after fine-tuning, using the model arn (Amazon Resource Name). Results in an extra subsection in the User documentation:
image

The same section now contains a separate link at the end of the section that directs the user to a subpage with very detailed workflows on setting up and using Amazon Bedrock with Jupyter AI, including how to fine tune a based model to create a custom model and then call the custom model from Jupyter AI. See:
image

Clicking through on this leads to the following web page:
image
A "Back" button is also provided to return to the main user documentation page as can be seen on the screenshot above.

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.
@srdas srdas added the documentation Improvements or additions to documentation label Aug 6, 2024
pre-commit-ci bot and others added 8 commits August 6, 2024 06:47
* fix settings save

* show placeholder message when API keys section is empty
Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.
Added a link in the section on Amazon  Bedrock Usage in the docs to a subpage titled `Using Amazon Bedrock with Jupyter AI` which offers a detailed workflow for using Bedrock models, fine tuning them, and calling them in Jupyter AI.
@srdas
Copy link
Collaborator Author

srdas commented Aug 9, 2024

@JasonWeill Thanks for your comment ("I'm a bit concerned by how much we're adding that's specific to Amazon Bedrock, including screenshots of the console, instead of deferring to the AWS docs. I'm wondering if we could solicit a review from someone outside AWS, to get an impartial opinion about this").

I have shortened the main user documentation to include only usage in Jupyter AI, and linked it to a subpage where all Bedrock usage details are provided more extensively. Note the new screenshots above.

@JasonWeill
Copy link
Collaborator

There are two one-sentence paragraphs near the big table of model providers that say, "To use the Bedrock models, you need access to the Bedrock service. For more information, see the Amazon Bedrock Homepage. … To use Bedrock models, you will need to authenticate via boto3." It might be good to merge these two into one, and to either add a sentence with a link to the Bedrock subpage to the or replace these with a link to the Bedrock subpage.

It might also be good to add a link to "Using Amazon Bedrock with Jupyter AI" to the top of the "Amazon Bedrock Usage" section, either in addition to or instead of the link at the bottom.

The "<--Back" link doesn't look quite right, both because it doesn't use an actual arrow character like ← and because it sends the user back to a place where they may not have been — for example, if they landed on the "Using Amazon Bedrock with Jupyter AI" page from a search engine query. See #655 — this might be better suited for the curiously empty "Section Navigation" in the left pane, to display a hierarchy of documents.

srdas and others added 2 commits August 9, 2024 12:47
@srdas
Copy link
Collaborator Author

srdas commented Aug 9, 2024

@JasonWeill Thanks so much for the comments. I have addressed them as follows:

Edited the two one-sentence paragraphs down to a single one:
image

Added an additional link to the top of the "Amazon Bedrock Usage" page just below the first introductory paragraph.
image

Removed the vacant left panel that was unused. Addresses Issue #655
image

You are right, the "Back" button is not meaningful and unclear as to where it leads. I replaced it with an explicit link as shown
image

@srdas srdas requested a review from JasonWeill August 9, 2024 20:06
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a good improvement.

@srdas srdas merged commit 4351ad9 into jupyterlab:main Aug 10, 2024
8 checks passed
michaelchia pushed a commit to michaelchia/jupyter-ai that referenced this pull request Aug 12, 2024
* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix saving chat settings (jupyterlab#935)

* fix settings save

* show placeholder message when API keys section is empty

* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Subpage for Bedrock use

Added a link in the section on Amazon  Bedrock Usage in the docs to a subpage titled `Using Amazon Bedrock with Jupyter AI` which offers a detailed workflow for using Bedrock models, fine tuning them, and calling them in Jupyter AI.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates to user docs

Addresses comment by Jason Weill

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <[email protected]>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix saving chat settings (jupyterlab#935)

* fix settings save

* show placeholder message when API keys section is empty

* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Subpage for Bedrock use

Added a link in the section on Amazon  Bedrock Usage in the docs to a subpage titled `Using Amazon Bedrock with Jupyter AI` which offers a detailed workflow for using Bedrock models, fine tuning them, and calling them in Jupyter AI.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates to user docs

Addresses comment by Jason Weill

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants