Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling and messaging when the chat service doesn't work #88

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Error handling and messaging when the chat service doesn't work #88

merged 2 commits into from
Apr 18, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Apr 18, 2023 •
edited
Loading

Fixes #83

  • UI shows an error message in the chat widget if there is a network error, this is a side-effect of missing env value for chat provider.
  • The users can keep using the magics in the notebook if chat doesn't work.
  • Removed some redundant code from handlers.

Screen Shot 2023-04-17 at 6 13 06 PM

@3coins 3coins added the bug Something isn't working label Apr 18, 2023
@3coins 3coins added this to the Milestone 3 milestone Apr 18, 2023
@3coins 3coins requested a review from JasonWeill April 18, 2023 01:27
@3coins 3coins marked this pull request as ready for review April 18, 2023 01:29
@ellisonbg ellisonbg merged commit 77a6256 into jupyterlab:main Apr 18, 2023
@3coins 3coins deleted the add-missing-env-error branch June 9, 2023 03:23
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@3coins
Error handling and messaging when the chat service doesn't work (jupy…
aaafdec 
…terlab#88)

* WIP: fix missing env

* Added error handling when chat provider key is missing
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@3coins @Marchlak
Error handling and messaging when the chat service doesn't work (jupy…
d2d47c0 
…terlab#88)

* WIP: fix missing env

* Added error handling when chat provider key is missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonbg ellisonbg ellisonbg approved these changes

@JasonWeill JasonWeill Awaiting requested review from JasonWeill

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0 Release
Development

Successfully merging this pull request may close these issues.

Missing api keys for ChatProvider causes Jupyter Lab to hang
2 participants
@3coins @ellisonbg