Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bedrock provider #263

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Added Bedrock provider #263

merged 5 commits into from
Jul 13, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Jul 11, 2023

Summary

Adds support for Bedrock Language Model.

Fixes #258

Result of %ai list.
Screen Shot 2023-07-12 at 12 25 50 PM

@3coins 3coins added the enhancement New feature or request label Jul 11, 2023
@3coins 3coins added this to the 0.10.0 Release milestone Jul 11, 2023
@3coins 3coins self-assigned this Jul 11, 2023
@3coins 3coins marked this pull request as ready for review July 11, 2023 18:44
@3coins 3coins added the bug Something isn't working label Jul 12, 2023
@JasonWeill
Copy link
Collaborator

Can you please update the user docs to refer to Bedrock? Does %ai list look OK with this new provider?

dlqqq
dlqqq previously approved these changes Jul 12, 2023
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🎉

@dlqqq dlqqq dismissed their stale review July 12, 2023 18:53

didn't see @JasonWeill's comment

@3coins
Copy link
Collaborator Author

3coins commented Jul 12, 2023

@JasonWeill
Update docs as per your comment.

docs/source/users/index.md Outdated Show resolved Hide resolved
@3coins 3coins merged commit 0f61906 into jupyterlab:main Jul 13, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* Added Bedrock provider

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Added Bedrock info to docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/source/users/index.md

Co-authored-by: Jason Weill <[email protected]>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jason Weill <[email protected]>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Added Bedrock provider

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Added Bedrock info to docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/source/users/index.md

Co-authored-by: Jason Weill <[email protected]>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jason Weill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create new Provider if model_id_key="model_id"
3 participants