Validate JSON for request schema #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
added
@jupyter-ai/magics
@jupyter-ai/chatui
enhancement
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
JasonWeill
force-pushed
the
validate-schema
branch
from
fcebeea
to
842400d
Compare
|
@JasonWeill |
|
@3coins This change also affects the settings panel, although I didn't include a screen shot of it |
|
Effect on the chat panel settings:
|
dlqqq
previously requested changes
Jul 13, 2023
Co-authored-by: david qiu <[email protected]>
dlqqq
approved these changes
Jul 17, 2023
3coins
reviewed
Jul 17, 2023
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Corrects capitalization for SageMaker endpoint * WIP: Pass expected format in model for field * Validates JSON using JSON.parse * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * WIP: Validate JSON in magics * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix reference to error * Update packages/jupyter-ai-magics/jupyter_ai_magics/magics.py Co-authored-by: david qiu <[email protected]> * Avoids redundant parameter --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: david qiu <[email protected]>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Corrects capitalization for SageMaker endpoint * WIP: Pass expected format in model for field * Validates JSON using JSON.parse * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * WIP: Validate JSON in magics * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix reference to error * Update packages/jupyter-ai-magics/jupyter_ai_magics/magics.py Co-authored-by: david qiu <[email protected]> * Avoids redundant parameter --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: david qiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202 (request schema only).
Validates JSON for the SageMaker endpoint's request schema. (The response path is JsonPath, for which I haven't found a good parser/validator yet.) This change affects both the magic commands and the chat UI.
In the following example, a correct schema (blue arrow) is accepted, while an incorrect schema (red arrow) is rejected with an exception.