-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat UI quality of life improvements #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR also includes many other changes from other branches; could you rebase the pertinent commits back onto main
? For example:
git checkout main
git pull
git checkout -
git rebase HEAD~3 chat-ui-tweaks --onto main
git push -f
6614ce7
to
b9fb482
Compare
b9fb482
to
450143d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks and works well.
At the same time if we want Jupyternaut to be seen as another collaborator in RTC chat environment, more neutral chat input placeholder at L48 like "Send a message" would work better. Call to action can then be part of a placeholder (as well as instructions and example prompts) that is shown when there are no messages in the chat (separate PR). I might be missing context here so feel free to ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Awesome work @JasonWeill 🎉
@andrii-i These are good suggestions, but right now, the AI always responds to the user. So the placeholder "Ask Jupyternaut anything" makes sense. Once we implement multi-user rooms that require the AI to be mentioned before responding, then we can change the placeholder. 👍
* Updates screen shot with placeholder * Incorporates change to code
* Updates screen shot with placeholder * Incorporates change to code
Fixes #55 (remaining tasks)
Adds a placeholder message for the chat box:
Adds a tooltip for the send message button:
Updates a screen shot in the docs.