Migrate to ChatOllama base class in Ollama provider
#1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a separate file `ollama.py` as a unique provider. Refactored other code accordingly. Also changed the `Ollama` class to `ChatOllama` so that it can support binding tools to the LLM. Updated the imports to come from `langchain_ollama` instead of `langchain_community` Tested on several Ollama models, both LLMs and embedding models: `mxbai-embed-large`, `nomic-embed-text`, `ima/deepseek-math`, `mathstral`, `qwen2-math`, `snowflake-arctic-embed`, `mistral`, `llama3.1`, `starcoder2:15b-instruct`
for more information, see https://pre-commit.ci
srdas
changed the title
ollama providerollama provider file
dlqqq
changed the title
ollama provider fileChatOllama base class in Ollama provider
dlqqq
approved these changes
Sep 26, 2024
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Added separate `ollama` provider Created a separate file `ollama.py` as a unique provider. Refactored other code accordingly. Also changed the `Ollama` class to `ChatOllama` so that it can support binding tools to the LLM. Updated the imports to come from `langchain_ollama` instead of `langchain_community` Tested on several Ollama models, both LLMs and embedding models: `mxbai-embed-large`, `nomic-embed-text`, `ima/deepseek-math`, `mathstral`, `qwen2-math`, `snowflake-arctic-embed`, `mistral`, `llama3.1`, `starcoder2:15b-instruct` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code to create a separate file for models provided by Ollama:
ollama.pyas a unique provider. Refactored other code accordingly.Ollamaclass toChatOllamaso that it can support binding tools to the LLM.langchain_ollamainstead oflangchain_communitymxbai-embed-large,nomic-embed-text,ima/deepseek-math,mathstral,qwen2-math,snowflake-arctic-embed,mistral,llama3.1,starcoder2:15b-instructReference: https://github.com/langchain-ai/langchain/blob/master/libs/partners/ollama/langchain_ollama/chat_models.py