Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Rendering artifacts lead to false positive #32

Closed
maartenbreddels opened this issue Apr 20, 2021 · 3 comments
Closed

Rendering artifacts lead to false positive #32

maartenbreddels opened this issue Apr 20, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@maartenbreddels
Copy link

Description

I'm seeing false positives, described at spacetelescope/jdaviz#543 (comment) . The capture of the output cells seems ok, but it seems to be capturing a part of the Jupyter Lab 3.0 interface (with different portions grey each time). I'm not sure this is a user bug or a Galata bug.

@maartenbreddels maartenbreddels added the bug Something isn't working label Apr 20, 2021
@welcome
Copy link

welcome bot commented Apr 20, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@mbektas
Copy link
Member

mbektas commented Apr 22, 2021

@maartenbreddels this is a bit surprising, cell output captures should have recorded only the output area. Can you try these:

  • Can you make sure reference images are generated by GitHub Actions as described here?
  • I checked the notebook tested, it seems to create an Application as cell output. Is it creating widget UI asynchronously in multiple steps? Is the cell output rendered after a noticeable wait? Are there multiple resizes happening before cell output is fully rendered? In that case adding a wait after cell execution could help. As the first line of onAfterCellRun function, you can try adding await galata.waitFor(2000); for example.
  • Can I test this notebook in binder or similar web location?

@fcollonval fcollonval mentioned this issue Aug 30, 2021
3 tasks
@mbektas
Copy link
Member

mbektas commented Sep 1, 2021

@maartenbreddels Galata had several updates since you reported this issue and recently the project was merged into JupyterLab core repository with this PR jupyterlab/jupyterlab#10796. Please test again with the latest Galata package and create an issue in https://github.com/jupyterlab/jupyterlab if problem persists.

@mbektas mbektas closed this as completed Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants