-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving jupyter_chat
into jupyterlab
org
#247
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Thanks @brichet for proposing this 👍
Just to clarify the intent, is the "it would be better" because Jupyter AI is currently mostly maintained by a team at AWS, and this team can only contribute to repos under GitHub orgs that are owned by and governed by Jupyter? As per this comment: #172 (comment)
Or for other reasons? Because technically speaking it's fine to depend on packages outside of the JupyterLab organization. |
Thanks @jtpio for the clarification, I forgot to mention this point. |
Confirming that constraint we have at AWS.
The other dimension is that this is more-or-less a refactor of Jupyter AI,
so makes sense to keep it in the same org.
…On Fri, Apr 12, 2024 at 12:52 AM Nicolas Brichet ***@***.***> wrote:
Just to clarify the intent, is the "it would be better" because Jupyter AI
is currently mostly maintained by a team at AWS, and this team can only
contribute to repos under GitHub orgs that are owned by and governed by
Jupyter? As per this comment: #172 (comment)
<#172 (comment)>
Thanks @jtpio <https://github.com/jtpio> for the clarification, I forgot
to mention this point.
Indeed, the AWS team would like to contribute to the jupyter-chat
development, and needs it to be in a Jupyter governed subproject.
—
Reply to this email directly, view it on GitHub
<#247 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGXUDZUT3VFKXKA52OWATY46HDVAVCNFSM6AAAAABF5B3YYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGIYTEMBRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Brian E. Granger
Senior Principal Technologist, AWS AI/ML ***@***.***)
On Leave - Professor of Physics and Data Science, Cal Poly
@ellisonbg on GitHub
|
cc @jupyterlab/jupyterlab-council for awareness |
We discussed this on the JupyterLab/frontends call today and I proposed that we move this repo to JupyterLab org in one week time if there are no objections until then. I can help with making the move happen. @brichet volunteered to write an email to frontends council to ensure everyone had a chance to contribute or object. Out of habit we kept saying lab council but I think the email should go frontends council mailing list. |
One week has passed since the last comment. We also discussed this again yesterday during the weekly meeting and there were no objections: #229 (comment) So let's proceed with the move. @brichet are you able to transfer the repo? Otherwise I can likely help with this. |
Thanks @jtpio. |
The repo has been transferred: https://github.com/jupyterlab/jupyter-chat I opened jupyterlab/jupyter-chat#19 to list follow-up items. Thanks all! |
Context
The
jupyter-chat
repository is currently injupyterlab-contrib
organization: https://github.com/jupyterlab-contrib/jupyter-chatThis repository is a monorepo containing:
chat-jupyter
)chat-jupyter
to build a chat using websocket (python package isjupyter_ws_chat
and npm package isjupyter-ws-chat
)chat-jupyter
to build a collaborative chat using shared document (python package isjupyter_collaborative_chat
and npm package isjupyter-collaborative-chat
)The front end package and the extension using websocket are mostly a reorganization of the chat used in
jupyter-ai
in a new repo (jupyter-ai
is already in the jupyterlab org).Problem
jupyter-ai
would like to use thejupyter-collaborative-chat
as a dependency, to avoid us (Jupyter developers) to maintain 2 chats.It would be better for
jupyter-ai
to depend on a repo in an official Jupyter organization.Proposed Solution
jupyter-chat
repository in the Jupyterlab organization.@jupyter/chat
.cc. @SylvainCorlay @ellisonbg @Zsailer @JasonWeill
The text was updated successfully, but these errors were encountered: