Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving jupyter_chat into jupyterlab org #247

Closed
brichet opened this issue Apr 8, 2024 · 9 comments
Closed

Moving jupyter_chat into jupyterlab org #247

brichet opened this issue Apr 8, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@brichet
Copy link

brichet commented Apr 8, 2024

Context

The jupyter-chat repository is currently in jupyterlab-contrib organization: https://github.com/jupyterlab-contrib/jupyter-chat

This repository is a monorepo containing:

  • a front end package, to be used in a Jupyter extension or remix (npm package is chat-jupyter)
  • a chat extension based on chat-jupyter to build a chat using websocket (python package is jupyter_ws_chat and npm package is jupyter-ws-chat)
  • a chat extension based on chat-jupyter to build a collaborative chat using shared document (python package is jupyter_collaborative_chat and npm package is jupyter-collaborative-chat)

The front end package and the extension using websocket are mostly a reorganization of the chat used in jupyter-ai in a new repo (jupyter-ai is already in the jupyterlab org).

Problem

jupyter-ai would like to use the jupyter-collaborative-chat as a dependency, to avoid us (Jupyter developers) to maintain 2 chats.
It would be better for jupyter-ai to depend on a repo in an official Jupyter organization.

Proposed Solution

  • Include jupyter-chat repository in the Jupyterlab organization.
  • Include the front end package in the Jupyter namespace of NPM, because it aims to be the front end for a chat in a Jupyter front end extension or remix. This package could be renamed @jupyter/chat.

cc. @SylvainCorlay @ellisonbg @Zsailer @JasonWeill

@brichet brichet added the enhancement New feature or request label Apr 8, 2024
Copy link

welcome bot commented Apr 8, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio
Copy link
Member

jtpio commented Apr 12, 2024

Thanks @brichet for proposing this 👍

It would be better for jupyter-ai to depend on a repo in an official Jupyter organization.

Just to clarify the intent, is the "it would be better" because Jupyter AI is currently mostly maintained by a team at AWS, and this team can only contribute to repos under GitHub orgs that are owned by and governed by Jupyter? As per this comment: #172 (comment)

My team at AWS has permission to contribute to GitHub orgs that are owned by and governed by Jupyter and we don't have permission to contribute it to other open source projects, such as jupyterlab-contrib at this time (for those who may not be familiar, the jupyterlab-contrib org is not a Jupyter governed subproject). This type of constraint is fairly typical of US-based tech companies - I know we aren't alone on that.

Or for other reasons? Because technically speaking it's fine to depend on packages outside of the JupyterLab organization.

@brichet
Copy link
Author

brichet commented Apr 12, 2024

Just to clarify the intent, is the "it would be better" because Jupyter AI is currently mostly maintained by a team at AWS, and this team can only contribute to repos under GitHub orgs that are owned by and governed by Jupyter? As per this comment: #172 (comment)

Thanks @jtpio for the clarification, I forgot to mention this point.
Indeed, the AWS team would like to contribute to the jupyter-chat development, and needs it to be in a Jupyter governed subproject.

@ellisonbg
Copy link
Contributor

ellisonbg commented Apr 12, 2024 via email

@jtpio
Copy link
Member

jtpio commented Apr 16, 2024

cc @jupyterlab/jupyterlab-council for awareness

@krassowski
Copy link
Member

We discussed this on the JupyterLab/frontends call today and I proposed that we move this repo to JupyterLab org in one week time if there are no objections until then. I can help with making the move happen. @brichet volunteered to write an email to frontends council to ensure everyone had a chance to contribute or object. Out of habit we kept saying lab council but I think the email should go frontends council mailing list.

@jtpio
Copy link
Member

jtpio commented Apr 25, 2024

One week has passed since the last comment.

We also discussed this again yesterday during the weekly meeting and there were no objections: #229 (comment)

So let's proceed with the move. @brichet are you able to transfer the repo? Otherwise I can likely help with this.

@brichet
Copy link
Author

brichet commented Apr 25, 2024

Thanks @jtpio.
I don't have authorization on either of the 2 organizations, so please proceed with the transfer.

@jtpio
Copy link
Member

jtpio commented Apr 25, 2024

The repo has been transferred: https://github.com/jupyterlab/jupyter-chat

I opened jupyterlab/jupyter-chat#19 to list follow-up items.

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants