Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup teams and permissions within the JupyterLab GitHub organization #167

Closed
jtpio opened this issue Dec 2, 2022 · 8 comments
Closed
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Dec 2, 2022

Problem

As of today, there seems to be quite a few teams in the jupyterlab org on GitHub: https://github.com/orgs/jupyterlab/teams

Also some repos have individual contributors added as collaborators.

With the rollout of the new governance model and the creation of the JupyterLab Council, it could make sense to streamline how teams and organization members are managed.

Proposed Solution

Probably we could do a bit of cleanup and delete some of the existing teams as they seem redundant. For example JupyterLab-and-NotebookTeam and JupyterLab Council.

Some could be removed like toc-extension and lumino (if we consider Lumino falls under the responsibility of the JupyterLab Council)

We can check whether some permissions for individual contributors should still be in place to not block them in their work. Or add them to the relevant team.

@jtpio jtpio added the enhancement New feature or request label Dec 2, 2022
@jtpio
Copy link
Member Author

jtpio commented Dec 2, 2022

Probably we could remove the committers team, and give commit access to the JupyterLab Council team instead.

Having only one list of committers would be easier to manage, and would follow the council process. So folks would for example not have commit access when they leave the council.

@jtpio
Copy link
Member Author

jtpio commented Feb 16, 2023

Some teams were created to work on extensions developed outside of code JupyterLab (debugger, toc). Also the JupyterLab maintainers also maintain other repos such as the cookiecutters, Lumino, and the localization toolchain.

Proposal:

  • we only keep the following teams:
    • JupyterLab Council
    • triage

image

  • the "JupyterLab Council" team has write access to all the repositories under the jupyterlab organization
  • the "triage" team has triage rights on all the repositories under the jupyterlab organization
  • if someone needs access to a particular repo we can document that they can ping the JupyterLab Council team on GitHub or privately
  • individual contributors on existing repos in the jupyterlab organization are left untouched
  • new teams can still be temporarily created later on if needed, for example to incubate a specific project with contributors that are not part of the JupyterLab Council

@jupyterlab/jupyterlab-council

@jasongrout
Copy link
Contributor

jasongrout commented Feb 16, 2023

Definitely +1 for simplifying the number and scope of teams, though I think there may still be a need for teams outside of the council and triage teams. However to simplify the cleanup, I would be +1 on initially deleting any teams other than the ones Jeremy proposes and then creating new teams as needed.

And Jeremy, I just deleted a few teams where only I or only you and I were members to help start the cleanup process.

@ellisonbg
Copy link
Contributor

ellisonbg commented Feb 16, 2023 via email

@fcollonval
Copy link
Member

Thanks Jeremy for pushing on this.

I agree as Brian.

@jtpio
Copy link
Member Author

jtpio commented Mar 14, 2023

FYI the old teams have been cleaned up as mentioned above.

I created a new "Release" team with a subset of maintainers for now, with Admin access to some repos of the organization. This should make it easier to give release rights to new people, especially now that we use the releaser bot for publishing packages to PyPI and npm (#165).

Let us know and feel free to open a new issue if you have any questions, thanks!

@jtpio jtpio closed this as completed Mar 14, 2023
@echarles
Copy link
Member

FYI the old teams have been cleaned up as mentioned above.

I have lost my commit rights further to this cleanup. Could someone restore them? Thx.

@echarles
Copy link
Member

I have lost my commit rights further to this cleanup. Could someone restore them? Thx.

Back on track with #186. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants