Fix CI

jupyterlab · Nov 14, 2023 · 6deefca · 6deefca
1 parent 6959868
commit 6deefca
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/shout-button-message/README.md b/shout-button-message/README.md
@@ -6,6 +6,11 @@ a widget in the status bar.
 
 ![preview](./preview.jpg)
 
+We strongly advice to look to those examples before diving into this one:
+
+- [signals](../signals/): Communication between JavaScript objects.
+- [widgets](../widgets): The basic DOM Jupyter component
+
 ## Jupyter Notebook / JupyterLab compatibility
 
 As Jupyter Notebook 7+ is built with components from JupyterLab, and since

diff --git a/shout-button-message/pyproject.toml b/shout-button-message/pyproject.toml
@@ -5,7 +5,7 @@ build-backend = "hatchling.build"
 [project]
 name = "jupyterlab_examples_shout_button"
 readme = "README.md"
-license = { file = "LICENSE" }
+license = {text = "BSD-3-Clause License"}
 requires-python = ">=3.8"
 classifiers = [
     "Framework :: Jupyter",

diff --git a/widgets/ui-tests/tests/widgets.spec.ts b/widgets/ui-tests/tests/widgets.spec.ts
@@ -10,15 +10,20 @@ test('should open a widget panel', async ({ page }) => {
   // Open a new tab from menu
   await page.menu.clickMenuItem('Widget Example>Open a Tab Widget');
 
-  await page.getByRole('main').getByText('Widget Example View');
-
-  let gotAlerted = false;
+  let resolveAlert: (arg0: boolean) => void;
+  const gotAlerted = new Promise<boolean>(resolve => {
+    resolveAlert = resolve;
+  });
   page.on('dialog', dialog => {
-    gotAlerted = dialog.message() == 'You clicked on the widget';
+    if (dialog.message() == 'You clicked on the widget') {
+      resolveAlert(true);
+    }
+    dialog.accept();
   });
-  await page.getByRole('main').locator('.jp-example-view').click();
 
-  expect(gotAlerted).toEqual(true);
+  await page.getByRole('main').getByLabel('Widget Example View').click();
+
+  expect(await gotAlerted).toEqual(true);
 
   expect(await page.screenshot()).toMatchSnapshot('widgets-example.png');
 });
diff --git a/widgets/ui-tests/tests/widgets.spec.ts-snapshots/widgets-example-linux.png b/widgets/ui-tests/tests/widgets.spec.ts-snapshots/widgets-example-linux.png