Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refresh button #41

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

madhur-tandon
Copy link
Member

@madhur-tandon madhur-tandon commented Mar 21, 2022

Closes #24

src/searchReplace.tsx Show resolved Hide resolved
@@ -36,6 +36,10 @@
display: flex;
}

.search-title-with-refresh {
display: flex;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add some vertical alignment and place the button on the far right (for that you will need to make the text node growing/shrinking).

Could you also set the color to var(--jp-ui-font-color1) - so it it styled properly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address CSS in another PR and merge this for now?

@madhur-tandon madhur-tandon merged commit c9e1292 into jupyterlab-contrib:master Mar 22, 2022
@madhur-tandon madhur-tandon deleted the refresh-button branch March 22, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] Refresh search button
2 participants