add options for search input #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollonval
reviewed
Mar 12, 2022
|
Indeed you need to update the styles - I would align on the same row the search box and he buttons (you can try setting the Definitely need to add tests. |
madhur-tandon
force-pushed
the
option-buttons
branch
from
b5a3a03 to
5f6ef02
Compare
madhur-tandon
force-pushed
the
option-buttons
branch
from
0e61890 to
0a69fd0
Compare
|
@fcollonval should be ready to merge I guess |
fcollonval
requested changes
Mar 18, 2022
|
@fcollonval this is ready for merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
I think more work is needed in terms of UI + check if results are being changed on toggling of the options.