add progress bar #37
Merged
add progress bar #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could try wrapping in a Promise.all to waitforselector (progessbar) and fill search at the same time. Hopefully the progress bar is at least displayed in one frame. |
|
@fcollonval I can see it, though it's available for a very short time. The fix was to emit state change in it's setter. |
fcollonval
reviewed
Mar 12, 2022
fcollonval
reviewed
Mar 12, 2022
fcollonval
reviewed
Mar 12, 2022
fcollonval
reviewed
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
@fcollonval not sure I can verify if this works -- since the query is too fast I guess OR I might be doing it incorrectly