Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree view #32

Merged
merged 11 commits into from
Mar 12, 2022
Merged

Tree view #32

merged 11 commits into from
Mar 12, 2022

Conversation

madhur-tandon
Copy link
Member

@madhur-tandon madhur-tandon commented Mar 10, 2022 •
edited
Loading

Closes #21 and #22

fcollonval
fcollonval requested changes Mar 11, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some update to improve the look of the UI. Could you address the two following points?

src/searchReplace.tsx Show resolved Hide resolved
src/searchReplace.tsx Show resolved Hide resolved
@madhur-tandon
Copy link
Member Author

@fcollonval ready to merge I guess

fcollonval
fcollonval approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhur-tandon

@fcollonval fcollonval merged commit a1acc3b into jupyterlab-contrib:master Mar 12, 2022
@madhur-tandon madhur-tandon deleted the tree-view branch March 15, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[frontend] Tree view
2 participants
@madhur-tandon @fcollonval