Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search request + tests + schema + case-sensitive #15

Merged
merged 6 commits into from
Feb 21, 2022
Merged

search request + tests + schema + case-sensitive #15

merged 6 commits into from
Feb 21, 2022

Conversation

madhur-tandon
Copy link
Member

@madhur-tandon madhur-tandon commented Feb 20, 2022 •
edited
Loading

Solves #5 and #6

fcollonval
fcollonval requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhur-tandon I have some comments.

jupyterlab_search_replace/tests/test_handlers.py Outdated Show resolved Hide resolved
jupyterlab_search_replace/tests/test_handlers.py Show resolved Hide resolved
jupyterlab_search_replace/search_engine.py Outdated Show resolved Hide resolved
@madhur-tandon madhur-tandon changed the title search request + tests + schema search request + tests + schema + case-sensitive Feb 21, 2022
fcollonval
fcollonval approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

thanks @madhur-tandon

@fcollonval fcollonval merged commit e27c881 into jupyterlab-contrib:master Feb 21, 2022
@madhur-tandon madhur-tandon deleted the search-request branch February 21, 2022 14:31
madhur-tandon added a commit to madhur-tandon/search-replace that referenced this pull request Mar 3, 2022
@madhur-tandon
search request + tests + schema + case-sensitive (jupyterlab-contrib#15)
aaddbed 
* change route for search

* add test for no result + schema for server response

* adhere to lint

* fix Manifest

* suggested changes and schema validation

* add option for case-sensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhur-tandon @fcollonval