Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory token for jupytext customization #50

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 5, 2023

This:

  • will improve tree shaking when only requiring the token.
  • add a new token to customize the widget factory (for use in Jupytext)

Fixes partly #17 (comment) cc @nthiery

This will need to be backported on 3.x and then a PR will be required on jupytext itself (code already written and tested https://github.com/fcollonval/jupytext/tree/ft/support-lab-rise).

@fcollonval fcollonval added the enhancement New feature or request label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Binder 👈 Launch a Binder on branch jupyterlab-contrib/rise/enh/create-token-file

@fcollonval fcollonval force-pushed the enh/create-token-file branch from 29e3757 to 028ee43 Compare September 8, 2023 07:23
@fcollonval fcollonval merged commit e8dedca into main Sep 8, 2023
@fcollonval fcollonval deleted the enh/create-token-file branch September 8, 2023 09:22
@fcollonval fcollonval changed the title Move token to its own file Add factory token for jupytext customization Sep 8, 2023
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 8, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e8dedca3690c3b1d0812d18bc23c9febb24cd925
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50: Add factory token for jupytext customization'
  1. Push to a named branch:
git push YOURFORK 3.x:auto-backport-of-pr-50-on-3.x
  1. Create a PR against branch 3.x, I would have named this PR:

"Backport PR #50 on branch 3.x (Add factory token for jupytext customization)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval added a commit that referenced this pull request Sep 11, 2023
…zation) (#54)

* Backport PR #50: Add factory token for jupytext customization

* Fix tokens API
@fcollonval
Copy link
Member Author

Jupytext PR is up: mwouts/jupytext#1126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant