Add "leave-current-mode" command to move insert->normal->command. #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we know, jupyterlab is already a "modal" editor and (by default) has a "edit4" and "command" mode.
One switches between modes via Esc, a la vim.
It's rather nice to preserve this behavior when adding the vim-modes so that Esc conceptually moves "up" a mode,
from vim-insert/lvisual to vim-normal and from vim-normal to jupyterlab-command.
Add a "Leave Current Mode" command, which can be rebound to Esc rather than "Leave Insert Mode".
This PR does not change the default Esc binding, which is separately proposed in #70.
Please finish the following when submitting a pull request:
History.md
briefly documenting the change.If this is a release, additionally do the following:
package.json
jlpm install
to updateyarn.lock
Thanks!