Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open shared link #49

Merged
merged 2 commits into from
May 28, 2024
Merged

Open shared link #49

merged 2 commits into from
May 28, 2024

Conversation

skbitsp
Copy link
Contributor

@skbitsp skbitsp commented Mar 22, 2024

The fix is to read the url from the iframe and use docmanager to open it. The assumption is that the actual path will start after "/tree/". Since it will pick the first occurence of /tree/, there won't a conflict if a folder is named tree in the path.

Tested on local
Open file gif

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a Binder on branch skbitsp/jupyterlab-unfold/sk/open-files

@skbitsp skbitsp mentioned this pull request Mar 22, 2024
Closed
martinRenou
martinRenou approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit a1082c6 into jupyterlab-contrib:master May 28, 2024
@martinRenou martinRenou mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skbitsp @martinRenou @skakker