-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook tours, icons #29
Add notebook tours, icons #29
Conversation
ed7556e
to
371c616
Compare
@bollwyvl would you have time to look at the rebase? |
Yeah, meant to do that, but frankly don't remember what was
contentious/half done, so might take me a bit of looking.
|
Thanks for getting back. Don't worry then. I'll move forward with this to get closer to a release; there are still two points I want to address before that. |
Looking now... i see you already did the rebase. Rad! Looking now. |
Ran the setup locally and made some changes to the template-generated stuff which burned my eyes. I'll update the top comment with some thoughts on possible tasks to get this out the door... |
Looking at the list of stuff i added up top, it is again probably not worth blocking on this to get a major version alpha out that works with lab4/nb7, though some of the API changes would be breaking. Probably want a |
use schema directly include error count in button, fix watch linting
9a61af5
to
2ad049a
Compare
TourManager.addTour
#28tourManager
ts-jest
when using thetsconfig.json
setup that allows for importing schema, etc.IOptions
instead of ever-longer positional/optional args?label
to the launch args to be able to find by human-readable name?notebookPage
?ajv
$prefix/share
andlabextension
screens