-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with Jupyterlab 4 #15
Conversation
Thanks @mctoohey - typically I'll wait for JupyterLab 4.0.0-beta that will have API frozen before merging an upgrade in the main branch. |
@fcollonval Can we look to merge this in now that Jupyterlab 4.0 has been release? The test_isolated step is failing due to what I believe to be a bug in jupyterlab.browser_check. I will open a PR in that repo for that issue. |
Was able to fix the failing test by switching from |
Thanks @mctoohey If it is ok with you I'll build on top of this PR to modernize the code and fix the CI. |
* Bump dependencies * Switch to get default file browser by requiring IDefaultFileBrowser
Super excited to see this almost done, really appreciate it! |
@fcollonval Is the extension ready for a pypi release with these changes? I have not been able to get a local install to complete. |
Thanks @fcollonval, same question as @kevinjohncutler here. Any plan regarding the pypi release? |
Thanks for following up on this @fcollonval and fixing the build! |
Fixes #14
These changes will not be compatible with Jupyterlab<4
I'm not sure how you want to proceed. Happy to just leave this MR open and continue to maintain it until there is an official release of Jupyterlab 4.0