Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Jupyterlab 4 #15

Merged
merged 25 commits into from
Aug 22, 2023

Conversation

mctoohey
Copy link

@mctoohey mctoohey commented Mar 12, 2023

Fixes #14

These changes will not be compatible with Jupyterlab<4

I'm not sure how you want to proceed. Happy to just leave this MR open and continue to maintain it until there is an official release of Jupyterlab 4.0

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch mctoohey/jupyterlab-favorites/master

@fcollonval
Copy link
Member

Thanks @mctoohey - typically I'll wait for JupyterLab 4.0.0-beta that will have API frozen before merging an upgrade in the main branch.

@mctoohey
Copy link
Author

mctoohey commented Aug 5, 2023

@fcollonval Can we look to merge this in now that Jupyterlab 4.0 has been release? The test_isolated step is failing due to what I believe to be a bug in jupyterlab.browser_check. I will open a PR in that repo for that issue.

@mctoohey mctoohey changed the title Make compatible with Jupyterlab above 4.0.0a33 Make compatible with Jupyterlab 4 Aug 5, 2023
@mctoohey
Copy link
Author

mctoohey commented Aug 5, 2023

Was able to fix the failing test by switching from --no-chrome-check to --no-browser-check which is functional the same.

@fcollonval
Copy link
Member

Thanks @mctoohey

If it is ok with you I'll build on top of this PR to modernize the code and fix the CI.

@kevinjohncutler
Copy link

Super excited to see this almost done, really appreciate it!

@fcollonval fcollonval merged commit 3cfc916 into jupyterlab-contrib:main Aug 22, 2023
5 of 6 checks passed
@kevinjohncutler
Copy link

@fcollonval Is the extension ready for a pypi release with these changes? I have not been able to get a local install to complete.

@kamranesmaeili
Copy link

Thanks @fcollonval, same question as @kevinjohncutler here. Any plan regarding the pypi release?

@fcollonval fcollonval mentioned this pull request Oct 21, 2023
@mctoohey
Copy link
Author

Thanks @mctoohey

If it is ok with you I'll build on top of this PR to modernize the code and fix the CI.

Thanks for following up on this @fcollonval and fixing the build!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jupyterlab-favorites fails to load on Jupyterlab 4.0.0a33
4 participants