Require k8s 1.20+ and small cleanups based on assuming it #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @consideRatio |
|
Thank you yuvi!!! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Mar 23, 2022
jupyterhub/zero-to-jupyterhub-k8s#2635 Merge pull request #2635 from consideRatio/pr/remove-no-longer-needed-conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2591 by requiring k8s 1.20+ and dropping support for k8s 1.17-1.19 that are no longer supported by the major cloud providers.
As part of this, I also do some cleanup to not test against old versions, remove misc conditionals to support old versions, and updates misc documentation references found to old versions.