Filtered WrapSpawner #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for parsing groups string
Update README.md for documentation on FileteredSpawner
FilteredSpawning
minrk
reviewed
May 7, 2018
| def get_user_groups(self): | ||
| import subprocess, sys | ||
| user = self.user.name | ||
| cmd_result = subprocess.Popen("groups "+user, shell=True, stdout=subprocess.PIPE).stdout.read() |
There was a problem hiding this comment.
This is not a safe or generic way to get groups. It assumes users are local on the Hub system, which is not generally true.
| groups_list = cmd_result.decode(sys_encoding).split(':')[1].replace('\n', '').strip().split(' ') | ||
| return groups_list | ||
|
|
||
| def _user_profiles(self): |
There was a problem hiding this comment.
Rather than implementing logic specific to your use case (filtering based on OS groups), maybe this filter should itself be a hook and then your configuration would register the appropriate filter function for your use case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
for internal purposes we had the necessity to integrate ProfileSpawner with a filter in order to provide to each user only an allowed set of profiles based on his group. We developed this feature in the FilteredSpawner class based on ProfileSpawner.
Each spawning profile has an additional parameter that allows to define a comma-separated list of authorized user groups. If * is specified instead of the comma-separated list the profile is available for all the users.
We found this integration quite useful, and we'd like to share it with the community.
Details in the README.md, let me know for any questions.
Thank you.
L.