Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update black 19.10b0, target Python 3.5 #849

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

manics
Copy link
Member

@manics manics commented Feb 14, 2020

In #848 I ran into problems with black auto-formatting some new code in a way that incompatible with Python 3.5 (I think this issue is related: psf/black#419).

It looks like this is fixed in the latest black.

@consideRatio
Copy link
Member

LGTM - but i don't grasp the CI failures

@betatim
Copy link
Member

betatim commented Feb 18, 2020

Restarted CI jobs. The failures are probably because MRAN is down.

LGTM otherwise

@betatim betatim merged commit 9ba15a5 into jupyterhub:master Feb 18, 2020
@manics manics deleted the black-py35 branch February 18, 2020 10:52
markmo pushed a commit to markmo/repo2docker that referenced this pull request Jan 22, 2021
[MRG] Update black 19.10b0, target Python 3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants