Pin doc requirements to avoid CI breakages #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hopefully dependabot can take care of them
|
Re-opened with just the version pinning. |
|
What's the difference between the circleci and readthedocs builds- do we need both? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1050
This pins the versions of all doc dependencies, so we can rely on dependabot to check for problems with updates.
There's no dependabot.yml file in https://github.com/jupyterhub/repo2docker/tree/master/.github but it looks like dependabot has previously opened PRs in this repo: https://github.com/jupyterhub/repo2docker/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed
so presumably it's been configured elsewhere?