Skip to content

Commit

Permalink
Julia 0.6 needs Jupyter from py35 environment
Browse files Browse the repository at this point in the history
  • Loading branch information
minrk committed Feb 15, 2023
1 parent 18cbf55 commit 0f328e6
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion repo2docker/buildpacks/julia/julia_require.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ def get_build_env(self):
else:
julia_arch = "x86_64"
julia_arch_short = "x64"

if V(self.julia_version) < V("0.7"):
# IJulia with Julia 0.6 isn't compatible with more recent jupyter-core
# point it to the one in the kernel env
# I _think_ this is only relevant during installation
jupyter = "${KERNEL_PYTHON_PREFIX}/bin/jupyter"
else:
jupyter = "${NB_PYTHON_PREFIX}/bin/jupyter"
return super().get_build_env() + [
("JULIA_PATH", "${APP_BASE}/julia"),
("JULIA_HOME", "${JULIA_PATH}/bin"), # julia <= 0.6
Expand All @@ -91,7 +99,7 @@ def get_build_env(self):
("JULIA_VERSION", self.julia_version),
("JULIA_ARCH", julia_arch),
("JULIA_ARCH_SHORT", julia_arch_short),
("JUPYTER", "${NB_PYTHON_PREFIX}/bin/jupyter"),
("JUPYTER", jupyter),
]

def get_path(self):
Expand Down

0 comments on commit 0f328e6

Please sign in to comment.