Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo2docker (Python 3.10 by default) and BinderHub (switch to jupyter-server) #2517

Merged
merged 7 commits into from
Mar 9, 2023
Merged

Update repo2docker (Python 3.10 by default) and BinderHub (switch to jupyter-server) #2517

merged 7 commits into from
Mar 9, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 28, 2023

combines bot updates #2509 and #2515

closes #2509
closes #2515

@minrk minrk mentioned this pull request Feb 28, 2023
Closed
@manics
Copy link
Member

manics commented Feb 28, 2023

/test-this-pr

@jupyterhub-bot
Copy link
Collaborator

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@jupyterhub-bot
Copy link
Collaborator

Job status: success
Branch 'test-this-pr/2517' has been deleted

@manics
Copy link
Member

manics commented Feb 28, 2023 •
edited
Loading

We also need to modify

mybinder.org-deploy/mybinder/values.yaml

Lines 365 to 370 in 2b9d60d

if have_lab:
# if recent-enough lab is available, make it the default UI
sys.argv.insert(1, "--NotebookApp.default_url=/lab/")
# launch the notebook server
os.execvp("jupyter-notebook", sys.argv)

@manics
Copy link
Member

manics commented Feb 28, 2023

On the other hand this means we should be able to merge #2515 as soon as the bot picks up jupyterhub/binderhub#1635 since it has no effect here!

@minrk
remove singleuser.cmd override
21862c3 
inherit default from binderhub
@minrk
Copy link
Member Author

minrk commented Mar 1, 2023

I think that was a temporary workaround for testing, which should have been removed here when the BinderHub changes solidified. It's now removed here, so it's not set in two places.

@minrk
Copy link
Member Author

minrk commented Mar 1, 2023

/test-this-pr

@jupyterhub-bot
Copy link
Collaborator

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@jupyterhub-bot
Copy link
Collaborator

Job status: failure
Branch 'test-this-pr/2517' has been deleted

@minrk
test improved labapp detection
76a1c93 
remove when upstreamed to binderhub
@minrk
Copy link
Member Author

minrk commented Mar 1, 2023

/test-this-pr please

@jupyterhub-bot
Copy link
Collaborator

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@jupyterhub-bot
Copy link
Collaborator

Job status: success
Branch 'test-this-pr/2517' has been deleted

@minrk minrk mentioned this pull request Mar 1, 2023
Merged
@minrk
Copy link
Member Author

minrk commented Mar 1, 2023

/test-this-pr

@jupyterhub-bot
Copy link
Collaborator

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@jupyterhub-bot
Copy link
Collaborator

Job status: success
Branch 'test-this-pr/2517' has been deleted

@minrk minrk mentioned this pull request Mar 8, 2023
Closed
@minrk minrk merged commit 00c05f4 into jupyterhub:main Mar 9, 2023
@minrk minrk deleted the repo2docker-binderhub-update branch March 9, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minrk @manics @jupyterhub-bot