-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates binderhub chart to 1.0.0-0.dev.git.2816.h5db2f98 #2376
Conversation
This is a new duplicate PR of #2367. I recreated it to be 100% confident it was correctly outlining the relevant PR changes. @manics noted in the previous PR that:
|
@minrk upgrading to JupyterHub 3 would imply user servers needs to be restarted typically, but would they need to be that also in this binderhub situation with non-typical authenticators etc? The key question to answer is really how we should go about merging this though. |
Because we don't use hub auth, I don't think servers need to be restarted (They shouldn't but that doesn't mean they don't). The main thing a 2.0 upgrade does is drop all tokens, which doesn't affect Binder servers, which don't use those tokens. This should be an attended upgrade, and plan for some disruption, though. Just in case. |
@minrk I propose then I'll go for a merge in 45 minutes or so after a meeting, and then have a gke.mybinder.org server started to monitor for possible issues as a service user as well. |
Do we need to upgrade jupyterhub-singleuser in repo2docker or not? |
That's a BinderHub issue more than a mybinder.org issue, since mybinder.org doesn't launch jupyterhub-singleuser. |
Hmmm I'm unsure if this is acceptable to merge so I won't try it pending considerations about jupyterhub-singleuser in built images. |
35430bc
to
a2e0ef5
Compare
@consideRatio if you have time to watch it for a bit, this should be fine. The jupyterhub-singleuser shouldn't be an issue for mybinder.org since no jupyterhub code runs in user images. |
Updates mybinder to depend on the binderhub chart version
1.0.0-0.dev.git.2816.h5db2f98
from version0.2.0-0.dev.git.2782.h3ccfc44
.0.2.0-0.dev.git.2782.h3ccfc44
1.0.0-0.dev.git.2816.h5db2f98
null
null
PRs
jupyterhub/binderhub@3ccfc44...5db2f98
Related