Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Sphinx and other docs deps #1914

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Pin Sphinx and other docs deps #1914

merged 2 commits into from
Jun 1, 2021

Conversation

manics
Copy link
Member

@manics manics commented May 28, 2021

Sphinx 4.0.2 has broken the docs build: #1912 (comment)

To avoid problems like this in future this PR pins all docs dependencies and configures dependabot to bump versions for docs only.

@manics
Copy link
Member Author

manics commented May 28, 2021

Has dependabot been configured somewhere else for this repo? It's opened some PRs on this repo https://github.com/jupyterhub/mybinder.org-deploy/issues?q=label%3Adependencies+is%3Aclosed
but there's no configuration file, does that mean it's not needed?

@betatim
Copy link
Member

betatim commented May 31, 2021

I thought that dependabot doesn't need configuring, but that is based on it seemingly "at random" turning up on repos, not on actual knowledge :-/

Should we merge this (to fix the docs build) and see what dependabot ends up doing?

@betatim betatim changed the title Pinx Sphinx and other docs deps Pin Sphinx and other docs deps Jun 1, 2021
@betatim betatim merged commit 74f2cd7 into jupyterhub:master Jun 1, 2021
@betatim betatim mentioned this pull request Jun 1, 2021
@manics manics deleted the docs-deps branch June 1, 2021 16:47
@manics
Copy link
Member Author

manics commented Jun 1, 2021

@betatim I've opened #1919 to discuss dependabot config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants