Fix logout URL to fully logout. #59
Conversation
This URL shuts down the single-user server as well as logging out of the hub. Fixes #51.
src/index.ts
Outdated
| @@ -65,9 +66,9 @@ function activateHubExtension(app: JupyterLab, palette: ICommandPalette, mainMen | |||
|
|
|||
| commands.addCommand(CommandIDs.logout, { | |||
| label: 'Logout', | |||
| caption: 'Log out of the Hub', | |||
| caption: 'Shut down this server and log out of the Hub', | |||
There was a problem hiding this comment.
Is there a way that we can only logout users without shutting down their servers? I think we should have that ability as that is also possible in the classic interface.
There was a problem hiding this comment.
My understanding was that the issue in #51 was that the server was still accessible specifically because it was still running. I don't know if there is a way to leave the server running while also logging out in the browser.
As far as I can see, though, this change uses the same logout URL as the classic interface ('/tree/'), so it should behave the same way.
There was a problem hiding this comment.
Ok, in that case we should keep the menu item label as "Log out...". Visiting the old link does not stop the pod.
|
Thanks a lot for helping out! And congrats on your first contribution. |
Fixes #51.
(Fair warning: I have not been able to test this change myself. I apologize for that.)