Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sanitised result of selected_subprotocol #446

Closed
wants to merge 1 commit into from
Closed

Use sanitised result of selected_subprotocol #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions jupyter_server_proxy/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ async def start_websocket_connection():
request=request,
on_message_callback=message_cb,
on_ping_callback=ping_cb,
subprotocols=self.subprotocols,
subprotocols=self.selected_subprotocol,
resolver=resolver,
)
self._record_activity()
Expand Down Expand Up @@ -530,14 +530,6 @@ def check_xsrf_cookie(self):
Defer to proxied apps.
"""

def select_subprotocol(self, subprotocols):
"""Select a single Sec-WebSocket-Protocol during handshake."""
self.subprotocols = subprotocols
if isinstance(subprotocols, list) and subprotocols:
self.log.debug(f"Client sent subprotocols: {subprotocols}")
return subprotocols[0]
return super().select_subprotocol(subprotocols)


class LocalProxyHandler(ProxyHandler):
"""
Expand Down
Loading