-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move proxy_request_options to configuration. #113
Conversation
Example app that requires a proxy request option: |
This is awesome, and we should definitely support configuring timeouts. However, I think we should explicitly support them, since otherwise we will be tied down to Tornado's HTTP Client implementation. I'd love to move to aiohttp at some point. |
Hello, thank you for your effort. I need to configure jupyterhub proxy timeouts (without monkey-patching the code preferably). I'll just wait for this to be merged, right? It cannot take long, definitely under half a year, right? |
@costa Are you able to help test this? |
@manics Let's see, I'm using the JupyterHub helm chart with a custom-built singleuser image which is built with installing |
Guys (no assumption here ;)), this PR has conflicts, I'm probably willing to test this if I have a chance to change the proxy request timeout without having to monkey-patch the code myself — and anyone can (fix the conflicts and) confirm it's worth the effort. |
:D I think unfortunately this PR didn't make it. While we do have a process ready timeout (
I think we should implement request timeout as its own option, rather than allowing arbitrary options to be passed through. That exposes internal detail of the project (which http client it uses) outside, making it impossible to change. With that, I'm going to close this. |
To address #112.