Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix closure reference when serving custom error pages #91

Merged
merged 1 commit into from
Dec 9, 2016
Merged

fix closure reference when serving custom error pages #91

merged 1 commit into from
Dec 9, 2016

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 9, 2016

this != that!

cf jupyterhub/jupyterhub#900

@minrk minrk mentioned this pull request Dec 9, 2016
Closed
@willingc
Copy link
Contributor

willingc commented Dec 9, 2016

@minrk I'm going to merge this. I reran the failing Travis job. I think that the failure is due to Travis' ability to build not the code.

@willingc willingc merged commit 7224fac into jupyterhub:master Dec 9, 2016
@minrk minrk deleted the handle_proxy_error-this branch December 9, 2016 16:06
@minrk
Copy link
Member Author

minrk commented Dec 9, 2016

thanks!

@rgbkrk
Copy link
Member

rgbkrk commented Dec 9, 2016

Yeah, nodejs has been having trouble with their hosted binaries in the last 24 hours or so. They're working on fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minrk @willingc @rgbkrk