Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support LTS and greater releases of node #82

Merged
merged 2 commits into from
Sep 30, 2016
Merged

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Sep 29, 2016

To use newer features of JavaScript and Node.js that are useful and performant (like native Object.assign, built-in Map), we should stick to more recent versions of Node.

@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 29, 2016

/cc @pseudomuto

@pseudomuto
Copy link
Contributor

pseudomuto commented Sep 29, 2016

Nice!

Might need to remove 0.12 as well

@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 29, 2016

I did it based on the LTS schedule, so even though I don't use 0.12 I left it in.

We can certainly cut 0.12 too though, I'm in favor.

@willingc
Copy link
Contributor

Whatever we ultimately decide re: 0.12, we should probably link to https://github.com/nodesource/distributions to give guidance to those users on slow moving LTS versions of Ubuntu or Fedora.

@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 29, 2016

I find it amusing that the tests are intermittently failing only on 0.12.

I agree with linking to node source's guidance with respect to LTS versions of Ubuntu and Fedora.

@willingc
Copy link
Contributor

Unless @minrk objects, I say remove 0.12 and we can link in the readme to the node guidance re: older versions.

@minrk
Copy link
Member

minrk commented Sep 30, 2016

👍 I've been meaning to add 6 for a while, but haven't had time to look at why the tests fail. It seems to be testing-related, as I'm pretty sure I've run CHP on node 6 without issues.

@minrk minrk merged commit 530c5d2 into master Sep 30, 2016
@minrk minrk deleted the rgbkrk-lts-greater branch September 30, 2016 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants